fix: vercel ci by gomesalexandre · Pull Request #775 · shapeshift/hdwallet

gomesalexandre · 2025-12-24T13:36:49Z

Fixes Vercel CI build failure by adding missing @shapeshiftoss/hdwallet-gridplus dependency to sandbox package.json.

Issue

The sandbox imports gridplus but didn't declare it as a dependency, causing Vite to fail during Vercel builds:

Failed to resolve entry for package "@shapeshiftoss/hdwallet-gridplus"

Changes

Added @shapeshiftoss/hdwallet-gridplus: 1.62.32 to examples/sandbox/package.json dependencies

This ensures lerna builds gridplus before the sandbox, allowing Vite to properly resolve the package.

Summary by CodeRabbit

Chores
- Updated example project dependencies.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

vercel · 2025-12-24T13:36:54Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
hdwallet	Ready	Preview, Comment	Dec 24, 2025 1:40pm

coderabbitai · 2025-12-24T13:36:59Z

📝 Walkthrough

Walkthrough

A new dependency @shapeshiftoss/hdwallet-gridplus (version 1.62.32) has been added to the examples/sandbox package.json file, expanding the available libraries for the sandbox environment.

Changes

Cohort / File(s)	Summary
Dependency Addition `examples/sandbox/package.json`	Added `@shapeshiftoss/hdwallet-gridplus@1.62.32` to dependencies

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

chore(release): publish 1.62.21 #757: Modifies examples/sandbox/package.json dependency entries for @shapeshiftoss/hdwallet-gridplus with version updates
fix: hdwallet-trezor mergefix #742: Updates @shapeshiftoss/hdwallet-gridplus and other package versions in dependency declarations

Poem

🐰✨ A gridplus friend joins the sandbox today,
Hopping through dependencies, lighting the way!
New wallets to test, new paths to explore,
With whiskers held high, we unlock the door! 🔑🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: vercel ci' directly addresses the main change: fixing a Vercel CI build failure by adding a missing dependency declaration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix_vercel_ci

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f9a0c59 and a46210b.

📒 Files selected for processing (1)

examples/sandbox/package.json

🧰 Additional context used

🧠 Learnings (9)

📓 Common learnings

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-coinbase/package.json:18-18
Timestamp: 2025-08-07T15:23:54.858Z
Learning: In the shapeshiftoss/hdwallet monorepo, package version bumps are done in PRs before publishing. The packages are published after the PR is merged, so dependency versions may reference unpublished versions during the PR review phase. This is expected behavior in their release workflow.

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger/package.json:36-36
Timestamp: 2025-08-07T15:27:03.179Z
Learning: In the shapeshiftoss/hdwallet monorepo, the ledgerhq/hw-transport dependency in packages/hdwallet-ledger/package.json is pinned to an exact version (without caret) due to type mismatches that occur with newer versions. Other Ledger dependencies can safely use caret ranges.

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 731
File: packages/hdwallet-gridplus/src/thormaya.ts:99-105
Timestamp: 2025-10-15T23:22:26.842Z
Learning: In packages/hdwallet-gridplus/src/thormaya.ts, the GridPlus SDK (gridplus-sdk) automatically pads the r and s signature components to 32 bytes, so explicit padding in the code may be redundant but is not required. The thorchainSignTx implementation works without explicit padding because the SDK handles it.

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 769
File: packages/hdwallet-walletconnectV2/src/walletconnectV2.ts:150-152
Timestamp: 2025-12-12T11:20:00.907Z
Learning: In the shapeshift/hdwallet monorepo, the `ethSupportsNetwork()` method in wallet implementations is a legacy/relic method that is no longer used. Chain support is determined by the `_supports*` flags (e.g., `_supportsMonad`, `_supportsPlasma`, `_supportsHyperEvm`) on the wallet classes, not by the `ethSupportsNetwork()` method.

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger-webusb/package.json:3-3
Timestamp: 2025-08-07T15:24:19.530Z
Learning: In the shapeshiftoss/hdwallet monorepo, the team runs `yarn build` before bumping versions and also before publishing packages. This ensures that dist/ artifacts (including UMD bundles) are properly regenerated after dependency updates.

📚 Learning: 2025-08-07T15:27:03.179Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger/package.json:36-36
Timestamp: 2025-08-07T15:27:03.179Z
Learning: In the shapeshiftoss/hdwallet monorepo, the ledgerhq/hw-transport dependency in packages/hdwallet-ledger/package.json is pinned to an exact version (without caret) due to type mismatches that occur with newer versions. Other Ledger dependencies can safely use caret ranges.

Applied to files:

examples/sandbox/package.json

📚 Learning: 2025-08-07T15:23:54.858Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-coinbase/package.json:18-18
Timestamp: 2025-08-07T15:23:54.858Z
Learning: In the shapeshiftoss/hdwallet monorepo, package version bumps are done in PRs before publishing. The packages are published after the PR is merged, so dependency versions may reference unpublished versions during the PR review phase. This is expected behavior in their release workflow.

Applied to files:

examples/sandbox/package.json

📚 Learning: 2025-08-07T15:24:19.530Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger-webusb/package.json:3-3
Timestamp: 2025-08-07T15:24:19.530Z
Learning: In the shapeshiftoss/hdwallet monorepo, the team runs `yarn build` before bumping versions and also before publishing packages. This ensures that dist/ artifacts (including UMD bundles) are properly regenerated after dependency updates.

Applied to files:

examples/sandbox/package.json

📚 Learning: 2025-08-07T15:47:29.207Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger/src/transport.ts:10-10
Timestamp: 2025-08-07T15:47:29.207Z
Learning: In the shapeshiftoss/hdwallet monorepo, ts-ignore is used instead of ts-expect-error for Ledger transport imports because the code works locally without TypeScript errors but has issues in CI environment. Using ts-expect-error would fail locally since there are no actual errors to suppress.

Applied to files:

examples/sandbox/package.json

📚 Learning: 2025-12-09T13:48:55.139Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 764
File: packages/hdwallet-gridplus/package.json:0-0
Timestamp: 2025-12-09T13:48:55.139Z
Learning: In the shapeshiftoss/hdwallet monorepo, the dist/ directory is not version controlled (not tracked in git). Build artifacts are generated during the build/publish workflow, not committed to the repository.

Applied to files:

examples/sandbox/package.json

📚 Learning: 2025-08-07T15:47:26.835Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger-webusb/src/transport.ts:12-12
Timestamp: 2025-08-07T15:47:26.835Z
Learning: In the shapeshiftoss/hdwallet monorepo, ts-ignore is used instead of ts-expect-error for Ledger transport imports because the CI environment has different type checking behavior than local development. The code works locally without errors, but CI reports type issues, so ts-ignore is necessary to suppress the inconsistent type checking across environments.

Applied to files:

examples/sandbox/package.json

📚 Learning: 2025-10-15T23:22:26.842Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 731
File: packages/hdwallet-gridplus/src/thormaya.ts:99-105
Timestamp: 2025-10-15T23:22:26.842Z
Learning: In packages/hdwallet-gridplus/src/thormaya.ts, the GridPlus SDK (gridplus-sdk) automatically pads the r and s signature components to 32 bytes, so explicit padding in the code may be redundant but is not required. The thorchainSignTx implementation works without explicit padding because the SDK handles it.

Applied to files:

examples/sandbox/package.json

📚 Learning: 2025-10-14T20:59:48.768Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 731
File: packages/hdwallet-gridplus/src/ethereum.ts:117-124
Timestamp: 2025-10-14T20:59:48.768Z
Learning: In packages/hdwallet-gridplus/src/ethereum.ts, the GridPlus SDK's sign method returns v as a number (integer), not a Buffer, so the Buffer.isBuffer(v) check is always false and vRaw = v is used directly.

Applied to files:

examples/sandbox/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build and Release

🔇 Additional comments (1)

examples/sandbox/package.json (1)

17-17: ✓ Dependency addition resolves the Vercel CI build failure.

The new dependency is correctly added with the appropriate version (1.62.32), properly ordered alphabetically, and follows the monorepo pattern of exact version pins for internal packages. The @shapeshiftoss/hdwallet-gridplus module is actively imported and used in the sandbox index.ts file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

fix: vercel ci

a46210b

gomesalexandre requested a review from a team as a code owner December 24, 2025 13:36

vercel Bot deployed to Preview December 24, 2025 13:40 View deployment

gomesalexandre merged commit fa8e703 into master Dec 24, 2025
5 checks passed

gomesalexandre deleted the fix_vercel_ci branch December 24, 2025 13:58

coderabbitai Bot mentioned this pull request Dec 26, 2025

fix: starknetjs version #776

Merged

1 task

Navigation Menu

Uh oh!

fix: vercel ci - #775

fix: vercel ci#775
gomesalexandre merged 1 commit into
masterfrom
fix_vercel_ci

gomesalexandre commented Dec 24, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Dec 24, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Dec 24, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

gomesalexandre commented Dec 24, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Changes

Summary by CodeRabbit

Uh oh!

vercel Bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gomesalexandre commented Dec 24, 2025 •

edited by coderabbitai Bot

Loading

vercel Bot commented Dec 24, 2025 •

edited

Loading

coderabbitai Bot commented Dec 24, 2025 •

edited

Loading